Results 46 comments of Stuart Caie

Thanks for the output. I will take a look.

Thanks very much for working on this! The support for building on Windows has been in need of modernisation for a while, and it's great that this works in harmony...

> 1. You can't open `"/dev/null"` in Windows. Instead, open `"NUL"` (with 1 "L"). It seems reasonable to put in a Windows-specific filename here. > 2. Defining `_LARGEFILE_SOURCE=1` and `_FILE_OFFSET_BITS=64`...

> libmspack has two modes of operation: > > 1. system.h defines LARGEFILE_SUPPORT **because** the underlying environment has 64-bit off_t and 64-bit file I/O (fseek/fseeko and ftell/ftello support 64-bit offsets)....

> After rebasing to include your changes and fix up a the mspack error message stuff, and add additional improvements to the autogen.sh script, I have found that 2/3 tests...

Thanks for the useful suggestion! I'm not sure what you mean about breaking the existing API. What would work perfectly well, I think, is the ability to supply more than...

I added the feature in commits c45f055 and cdcaeb9a445ba174dcc1adbf0777c83a3ee709f3 - please let me know if it works for you.

Thanks for testing. I fixed the issue you encountered in 56fe06f52403e7d19160767c6af060b2b528a2ff - I'd quite like to use C99 standards, but first I need to update the build scripts so they...

Thanks very much for looking for potential vulnerabilities. What's in this patch is already fixed, but please do share any other vulnerabilities you find in future.

> so, line 495 in kwajd.c is not necessary, isn't it? https://github.com/kyz/libmspack/blob/master/libmspack/mspack/kwajd.c#L495 Yes, that's correct. It could just be `if (lzh) lzh->sys->free(lzh);`