fix several potential vulnerabilities
fixing oob, null pointer deference
How about the last two commits?
so, line 495 in kwajd.c is not necessary, isn't it? https://github.com/kyz/libmspack/blob/master/libmspack/mspack/kwajd.c#L495
Thanks very much for looking for potential vulnerabilities. What's in this patch is already fixed, but please do share any other vulnerabilities you find in future.
so, line 495 in kwajd.c is not necessary, isn't it? https://github.com/kyz/libmspack/blob/master/libmspack/mspack/kwajd.c#L495
Yes, that's correct. It could just be if (lzh) lzh->sys->free(lzh);
so, line 495 in kwajd.c is not necessary, isn't it? https://github.com/kyz/libmspack/blob/master/libmspack/mspack/kwajd.c#L495
Yes, that's correct. It could just be
if (lzh) lzh->sys->free(lzh);
Gotcha. So, for coordinating the code should be changed.