Tatsuya Kyushima
Tatsuya Kyushima
@bashbunni Hi, I would be very appreciate if you rereview my changes when you get a chance. Thank you.
@bashbunni Thanks so much for fixing naming and updating logics. It looks better than mine. The tests failing seems like fixed by this: ```diff diff --git a/viewport/viewport.go b/viewport/viewport.go index 05e93ae..332134b...
@bashbunni I pushed a diff [I suggested](https://github.com/charmbracelet/bubbles/pull/578#issuecomment-2336611196) and verify that unit tests have passed on my machine by running `go test ./...`. If you have a moment, could you please...
@meowgorithm I'm sorry that I didn't reply to your review. I thought I have to take time to investigate scope to influenced by this PR to reply. But I could...
Thanks for using fzf-make and taking your time to submit this issue! It good idea! I'll take a look into it in my free time. ## Ref - https://ja.stackoverflow.com/questions/49684/%E8%87%AA%E4%BD%9C%E3%81%97%E3%81%9F%E3%82%BD%E3%83%95%E3%83%88%E3%82%A6%E3%82%A7%E3%82%A2%E3%82%92-apt-%E7%B5%8C%E7%94%B1%E3%81%A7%E3%82%A4%E3%83%B3%E3%82%B9%E3%83%88%E3%83%BC%E3%83%AB%E3%81%A7%E3%81%8D%E3%82%8B%E3%82%88%E3%81%86%E9%85%8D%E5%B8%83%E3%81%97%E3%81%9F%E3%81%84 -...
@pataquets Thanks for the input. I'll look into it time when I have some free time. Do we have to put binaries for both amd64 and arm64?
@Garfeild I'm sorry for the late reply. Good job! It seems fixed for me!
> Yeah I would like that but currently it's a bit cumbersome, because the app does network requests and that's hard to record. I just want to make sure I...
> Edit: just realized that's the last updated at column 🤷🏽 That's true. I want a `CreatedAt` column, not a `UpdatedAt` column. Do you agree with adding it? If so,...
@Sigmanificient Thanks for the report and taking time! Now, fzf-make parses `Makefile` by regex. But if using treesitter, issue like this will not cause. I will do it when I...