gh-dash icon indicating copy to clipboard operation
gh-dash copied to clipboard
verified publisher icon dlvhdr

[BUG] The sidebar does not render all the contents if the content includes a very long line

Open kyu08 opened this issue 1 year ago • 3 comments

Describe the bug

The sidebar does not render properly if the content includes a very long line. This makes approve textarea not be able to seen.

To Reproduce

Steps to reproduce the behavior:

  1. Select a PR including a very long line (e.g. https://github.com/kyu08/fzf-make/pull/295 )
  2. Scroll to the bottom by ctrl + d

Expected behavior

All the contents is rendered.

Screenshots

The sidebar can't all the contents. (The last line of the comment is This is the last line. But it is not rendered.)

image

Environments (please complete the following information):

  • OS: macOS
  • Commit hash: c524f60c308d

How to resolve

I submitted a PR to charmbracelet/bubbles to fix this problem by fixing height calculation method. https://github.com/charmbracelet/bubbles/pull/578 So if the PR is merged, bumping the version resolves this issue.

kyu08 avatar Aug 09 '24 10:08 kyu08

Looking forward for this to be resolved! 🔥

Garfeild avatar Oct 07 '24 10:10 Garfeild

@kyu08 Can you check my PR #466 whether it fixes issue for you?

Garfeild avatar Oct 17 '24 17:10 Garfeild

@Garfeild I'm sorry for the late reply. Good job! It seems fixed for me!

kyu08 avatar Nov 04 '24 08:11 kyu08