Kyle Plump

Results 28 comments of Kyle Plump

👋 i created a PR which fixes the `assets.json` generation, as well as the `favicon.ico` issue you're experiencing: https://github.com/hanami/assets-js/pull/31 i also added a commit to the original PR (https://github.com/hanami/cli/pull/221) which...

hi @dsisnero 👋 thanks for helping out! thats a good point about `bash.exe` being in your PATH. i've added your correct dev implementation to the PR have you run into...

thanks @timriley! i've included the tests for your review. lmk if this works

Thanks for the pointers @timriley! I would love to have a go at this My initial reaction would have been to create a new thread if the method is not...

thanks for the tip @pcopissa ! I think your suggestion is better than the original fix: - its seemingly more consistent - it does not rely on a failure to...

Hi @timriley, thanks for the response! Happy to help! I opened a PR to provide a default fallback to the `Hanami::CLI::Commands::App::Assets::Command#fork_child_assets_command` function that will rely on spawning instead: [#221](https://github.com/hanami/cli/pull/221). Lmk...

thank you for this @robyurkowski 🙂 ! I agree I think this is a nice guard rail to have with minimal cost. there are a few failing tests, do you...

@cllns @dcr8898 howdy gentlemen thank you for the thoughts! i think i made some headway here ## context i did some poking around to see if i could figure out...

@cllns @dcr8898 follow up here: ended up squeezing some more juice out of the 2.2.1 implementation (now named 2.2.12 although idk if this is the correct usage of semver or...

@cllns @dcr8898 i appreciate you both thinking about this so deeply! i love hearing your perspectives - trying to keep up with you two is helping me learn a ton...