Kyle Plump
Kyle Plump
@cllns that "345% slower" metric made me physically recoil 😐 i suspect it might be because of the fact that 2.2 delays creating Mustermann matchers - leading to potentially some...
hi @dcr8898, @cllns opened an issue related to this: [#279 ](https://github.com/hanami/router/pull/279) - would love to hear what you guys think about it!
thanks for checking this out @cllns ! fixed the rubocop offenses - this is an excellent point. i feel as though the better DX would be to _support_ and not...
hi @cllns 👋 (sorry its been 10 years) i just committed some changes. some thoughts: - relaxed the rack requirement - allowed handling of mixed case headers - injected content-length...
@timriley pinging you back. made a bunch of requested updates, and left a few comments 🙂 please let me know what you think. thanks!
@dcr8898 @francois @timriley (sorry creeping on this) I think i found the issue and @dcr8898 hit the nail on the head: its the fact that its multiple different slugs (e.g....
Thanks for the pointers @cllns! (still new to Hanami, and learning 😅 ). I made the change you suggested using `Pathname`. On the spec front: I noticed there was already...
Thanks! Lmk I'd be happy to add that utility method in if you guys think it would be useful
hi @pcopissa 👋 thank you for taking the time to investigate this issue so thoroughly! i'm sure windows users everywhere are thankful for your efforts. i believe we're both working...
👋 @pcopissa ## detecting windows this makes sense to me thank you for digging in here! Even though it seems most platform detection code is using regex, `Gem.win_platform?()` at least...