Kyle Gilde

Results 34 comments of Kyle Gilde

looks like there is more work to do. I can see if I can keep working through the Code Contributor list of steps.

I think that I fixed all the type bugs, but maybe not in the most efficient manner.

I should be able to find some time this week/weekend to add some tests.

Hi @solegalli, I implemented the changes we discussed and started creating the test file. It's my first time using pytest, so I'm experiencing a learning curve.

Hi @solegalli , I haven't heard from you in a little while. If I make all of the requested changes and pass the tests, are you still interested in merging...

I think it does make sense to have datetime transformers in its own module. I'll give #67 a look. Thanks!

I see that the datetime module was released today. If we wanted to proceed with a datetime subtraction class, would we just need to combine some parts of the DatetimeFeatures...

I might give it a go if I have some time this week/weekend.

should I create a datetime_subtraction.py script in the datetime folder?