Levi Zim

Results 124 comments of Levi Zim

Unfortunately, the aix CI failed again.

Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it? For reference, the set of tests that are flaky appears to be addons.stringbytes-external-exceed-max.test-stringbytes-external-at-max addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max...

Rebased to fix conflict in `v8_embedder_string`

It appears that we got another merge conflict. Let me rebase it.

The correct fix is https://github.com/nodejs/node/pull/58746 instead of increasing the gap. However, I think that PR missed its opportunity to make it into main branch. The v8 used in main branch...

> [@AyushAnand-28](https://github.com/AyushAnand-28) Can you confirm if you have you been able to build Node from `main` on RISC-V and if so which compiler did you use? I've had build failures...

> and for `main` I'm getting: > > ``` > In file included from ../deps/v8/third_party/highway/src/hwy/ops/scalar-inl.h:24, > from ../deps/v8/third_party/highway/src/hwy/highway.h:722, > from ../deps/v8/src/json/json-stringifier.cc:10: > ../deps/v8/third_party/highway/src/hwy/ops/shared-inl.h: In instantiation of 'struct hwy::N_SCALAR::detail::FixedTagChecker': > ../deps/v8/third_party/highway/src/hwy/ops/shared-inl.h:423:7:...

I remember that on SG2042, nodejs 25.2.1 with https://github.com/nodejs/node/pull/60591 and https://github.com/nodejs/node/pull/60588 applied passed all tests except `test-snapshot-reproducible.js`, which is currently being tracked upstream at https://issues.chromium.org/issues/460332153

> Thanks [@kxxt](https://github.com/kxxt) I'll take a look at those since I haven't run tests with those included yet and some of the failures were OOMs which could be related to...