[v24.x][riscv] Fix check failed in bind_to
Backport two V8 commits to fix a crash found while building Adguard Home using webpack https://github.com/riscv-forks/electron/issues/9.
This is only needed for v24.x.
The PR for the main branch(https://github.com/nodejs/node/pull/58746) has missed its opportunity because now v8 version on v25.x and main already contains these fixes.
Close #60895
Review requested:
- [ ] @nodejs/gyp
- [ ] @nodejs/security-wg
- [ ] @nodejs/v8-update
CI: https://ci.nodejs.org/job/node-test-pull-request/70392/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6900/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6900/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6900/
node-test-commit-aix failure seems unrelated.
node-test-commit-arm failure is caused by transit network error.
Probably we should retry the CI.
CI: https://ci.nodejs.org/job/node-test-pull-request/70395/
Unfortunately, the aix CI failed again.
CI: https://ci.nodejs.org/job/node-test-pull-request/70401/
Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it? For reference, the set of tests that are flaky appears to be
addons.stringbytes-external-exceed-max.test-stringbytes-external-at-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-ascii
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-base64
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-binary
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-utf8
(Collected from a few recent failed runs)
Rebased to fix conflict in v8_embedder_string
Issue for the AIX failures. I think it's fair to assume these are not related to this PR specifically (and the fix to mark it flaky should be in v24.x-staging now).
CI: https://ci.nodejs.org/job/node-test-pull-request/70422/
CI: https://ci.nodejs.org/job/node-test-pull-request/70426/
Failed to start CI
⚠ Commits were pushed since the last approving review: ⚠ - deps: V8: backport bbaae8e36164 ⚠ - deps: V8: cherry-pick 394a8053b59e ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20029272474
It appears that we got another merge conflict. Let me rebase it.
CI: https://ci.nodejs.org/job/node-test-pull-request/70431/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6912/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6912/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6912/
CI: https://ci.nodejs.org/job/node-test-pull-request/70443/
The CI is green now.
Landed in 2ac18ce50f76...105fbdd62455