node icon indicating copy to clipboard operation
node copied to clipboard

[v24.x][riscv] Fix check failed in bind_to

Open kxxt opened this issue 2 weeks ago • 22 comments

Backport two V8 commits to fix a crash found while building Adguard Home using webpack https://github.com/riscv-forks/electron/issues/9.

This is only needed for v24.x.

The PR for the main branch(https://github.com/nodejs/node/pull/58746) has missed its opportunity because now v8 version on v25.x and main already contains these fixes.

Close #60895

kxxt avatar Dec 05 '25 11:12 kxxt

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Dec 05 '25 11:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70392/

nodejs-github-bot avatar Dec 05 '25 13:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6900/

nodejs-github-bot avatar Dec 05 '25 13:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6900/

nodejs-github-bot avatar Dec 05 '25 13:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6900/

nodejs-github-bot avatar Dec 05 '25 13:12 nodejs-github-bot

node-test-commit-aix failure seems unrelated. node-test-commit-arm failure is caused by transit network error.

Probably we should retry the CI.

kxxt avatar Dec 06 '25 01:12 kxxt

CI: https://ci.nodejs.org/job/node-test-pull-request/70395/

nodejs-github-bot avatar Dec 06 '25 01:12 nodejs-github-bot

Unfortunately, the aix CI failed again.

kxxt avatar Dec 06 '25 07:12 kxxt

CI: https://ci.nodejs.org/job/node-test-pull-request/70401/

nodejs-github-bot avatar Dec 06 '25 13:12 nodejs-github-bot

Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it? For reference, the set of tests that are flaky appears to be

addons.stringbytes-external-exceed-max.test-stringbytes-external-at-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-ascii
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-base64
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-binary 
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-utf8

(Collected from a few recent failed runs)

kxxt avatar Dec 06 '25 13:12 kxxt

Rebased to fix conflict in v8_embedder_string

kxxt avatar Dec 06 '25 14:12 kxxt

Issue for the AIX failures. I think it's fair to assume these are not related to this PR specifically (and the fix to mark it flaky should be in v24.x-staging now).

sxa avatar Dec 08 '25 11:12 sxa

CI: https://ci.nodejs.org/job/node-test-pull-request/70422/

nodejs-github-bot avatar Dec 08 '25 12:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70426/

nodejs-github-bot avatar Dec 08 '25 12:12 nodejs-github-bot

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: V8: backport bbaae8e36164
   ⚠  - deps: V8: cherry-pick 394a8053b59e
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20029272474

github-actions[bot] avatar Dec 08 '25 13:12 github-actions[bot]

It appears that we got another merge conflict. Let me rebase it.

kxxt avatar Dec 08 '25 13:12 kxxt

CI: https://ci.nodejs.org/job/node-test-pull-request/70431/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6912/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6912/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6912/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70443/

nodejs-github-bot avatar Dec 08 '25 23:12 nodejs-github-bot

The CI is green now.

kxxt avatar Dec 10 '25 07:12 kxxt

Landed in 2ac18ce50f76...105fbdd62455

richardlau avatar Dec 10 '25 17:12 richardlau