Konrad Windszus

Results 602 comments of Konrad Windszus

One can use `@SuppressForbidden` for false positives (https://github.com/policeman-tools/forbidden-apis/issues/251).

I now refactored all methods relying on the default charset/locale/timezone. Please check again @reschke.

It is easier to always set it than to exclude some checks. Some other format specifiers are locale specific as well (integer)

> But the site has an an empty license body in https://codehaus-plexus.github.io/plexus-classworlds/licenses.html. This should probably be fixed by https://github.com/codehaus-plexus/plexus-pom/commit/a9d1aadd2bfc9089e921c856bd045e567927447b as it seems GitHub rather uses the pom.xml for the license...

For the actual ZIP generation the normalization is done by https://github.com/codehaus-plexus/plexus-archiver/blob/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36/src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipArchiver.java#L370. This is not called for `getFiles()` though.

Ok, the issue was that the check was performed on `AbstractArchiver.getFiles()` where the file name normalization has not happened yet. I wonder whether that is expected behaviour though. IMHO `AbstractArchiver.getFiles()`...

@plamentotev Indeed the generated ZIP file is correct (i.e. only contains forward slashes). It is just `AbstractArchiver.getFiles()` which behaves unexpectedly. I would expect the entry names as they appear in...

> and in fact, plain wrong. I disagree with this statement, and also disagree that they should be opt in. Details in the JIRA: https://issues.apache.org/jira/browse/MPLUGIN-522?focusedCommentId=17844188&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17844188

> Putting prerequisites which are greater than the one actually used to build are, at first, very weird. Let's focus on issue with the automatic detection. Please point me to...

For the record: The automatic detection in this case was not wrong it was just that the referenced artifact (JLine3) states it is Java8 compatible but contains Java22 bytecode classes...