Konrad Windszus

Results 602 comments of Konrad Windszus

I can't with the project from the description as you now require Java 11 to run aemanalyser (https://github.com/adobe/aemanalyser-maven-plugin/blob/d2df2a9ac36301a82a7a3887ee3b8eed7af903f0/parent-oss/pom.xml#L56).

The general issue is that aemanalyser assumes the same Java version being used at build time (when executing the maven plugin) as during execution time of the OSGi runtime. The...

As container packages are not supposed to have package dependencies in their metadata (compare with the long discussion in https://issues.apache.org/jira/browse/JCRVLT-443) those dependencies need to be added on another level: 1....

@vladbailescu As fix I would recommend to convert https://github.com/adobe/aem-core-wcm-components/blob/main/content/src/content/jcr_root/apps/core/wcm/components/experiencefragment/.content.xml to a proper component having `cq/experience-fragments/editor/components/experiencefragment` as resourceSuperType. WDYT?

I would open a PR but it seems that PRs from external contributors are no longer reviewed/merged in this project...

It is hard to exclude a dependency including its transitive dependencies in https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html. Also I stumbled upon https://issues.apache.org/jira/browse/MENFORCER-502 which leads to different behaviour when building the module standalone (success) vs...

Aren't lodash and underscore different libraries? IMHO ACS AEM Commons only embeds the former...

To answer my own question, according to https://www.geeksforgeeks.org/difference-between-lodash-and-underscore/ > Lodash’s API is a superset of Underscore. It provides every functionality that Underscore does, along with a few additional helpful functions...

There is already lots of issues regarding outdated angular: https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues?q=is%3Aissue+angular+is%3Aopen. Please rather comment on existing ones.