Noel Kwan

Results 371 comments of Noel Kwan

E2e test Runtime comparison (debug mode) ``` key: e2e_test/streaming/aggregate/hdr_approx_percentile.slt, diff: +1409, arrangement runtime: 10965, no shuffle runtime: 9556 key: e2e_test/streaming/./nexmark/create_views.slt.part, diff: +4248, arrangement runtime: 19953, no shuffle runtime: 15705 key:...

![Screenshot 2024-01-30 at 5 42 44 PM](https://github.com/risingwavelabs/risingwave/assets/47273164/30848d63-53b1-49cc-98f7-2acbd20bd7d8) Runtime still too long without the debug. 8 minutes vs 6 minutes for a normal PR https://buildkite.com/risingwavelabs/pull-request/builds/40961#018d590f-88cb-4868-9ad0-d57ad894bd8d

At least main-cron is not taking a long time for e2e test streaming. Seems to be an issue specific to debug mode. This PR `4m 34s`: ![Screenshot 2024-01-30 at 6...

- https://buildkite.com/risingwave-test/backfill/builds/387 - https://buildkite.com/risingwave-test/backfill/builds/386 Arrangement backfill passes backfill performance tests.

- no shuffle w tomb: https://buildkite.com/risingwave-test/backfill/builds/380#018e2f1b-c128-47ef-9cf5-1e5520587b05 - no shuffle w/o tomb: https://buildkite.com/risingwave-test/backfill/builds/379#018e2ee5-adf4-46a1-8fb9-b6a92e0c2a60 - arrangement w tomb https://buildkite.com/risingwave-test/backfill/builds/387 - arrangement no tomb https://buildkite.com/risingwave-test/backfill/builds/386 | | arrangement | no shuffle | arrangement...

To revert this PR: 1. set `streaming_use_arrangement_backfill` back to false by default. 2. Run `./risedev dapt` to reset stream scan to use backfill rather than arrangement backfill.

Main cron today https://buildkite.com/risingwavelabs/main-cron/builds/2104 seems to be failing as well due to TLE: For this main-cron for this PR: https://buildkite.com/risingwavelabs/main-cron/builds/2108# Importantly the runtime for backfill and e2e test does not...

Waiting for main-cron fixes https://github.com/risingwavelabs/risingwave/pull/15861, https://github.com/risingwavelabs/risingwave/pull/15908 before merging this in. To make sure no regressions are caused by arrangement backfill.

Fix parallel in memory tests here. https://github.com/risingwavelabs/risingwave/pull/15930

Previously fixed issue: https://github.com/risingwavelabs/risingwave/issues/14104. The fix should be already in 1.7. But this bug could be due to similar reasons.