Noel Kwan

Results 371 comments of Noel Kwan

Maybe can consider property tests here https://jsverify.github.io/#jsverify

To reproduce: ```rs use sqlparser::dialect::PostgreSqlDialect; use sqlparser::parser::Parser; fn main() { let sql = "SELECT -9223372036854775808;"; let dialect = PostgreSqlDialect {}; let ast = Parser::parse_sql(&dialect, sql).unwrap(); println!("AST: {:#?}", ast); } ```...

> For some `exists` query, e.g. > > > SELECT t1.* FROM t1 > > WHERE EXISTS (SELECT * FROM t3 WHERE t1.c1 = t3.c1) > > It can be...

~~Any updates?~~ Edit: Zongyu's laptop is broken unfortunately. Resume after new laptop is setup.

> Since this PR is not about correlated query, and it is about EXISTS, would it be alright if I dun generate correlated query (meaning I generate local context) and...

> This show that if I would want to generate correlated query (Not the local query), I need to pass the information about "Cannot have agg" all the way until...

Wondering if something like [`Quickcheck`'s `shrink`](https://hackage.haskell.org/package/QuickCheck-2.14.2/docs/Test-QuickCheck.html#g:6) would be useful here. Do generated queries get very complex and hard to debug? Perhaps can be used for other fuzzers we eventually use...

Remaining refinements / workarounds / bugs are tracked in #3896 . Closing this issue.

Took a further look, seems like flamegraph rendering depends on `inferno::flamegraph`. There's an open issue for that there: https://github.com/jonhoo/inferno/issues/256. I guess it has to be fixed upstream first, and just...

~Seems like it *might* have been fixed, will try to bump dependency and see how it is.~ Edit: After bumping dependency it's still slow, I realized it's a different issue...