Noel Kwan

Results 371 comments of Noel Kwan

In GitLab by @AlexKnauth on Jun 29, 2021, 03:05 marked this issue as related to #198

In GitLab by @AlexKnauth on Jun 29, 2021, 03:15 changed the description

In GitLab by @fahree on Jan 7, 2021, 03:03 For Ethereum-style networks, heed the `nativeCurrency.symbol` and other fields in the network we use (ethereum-config, from `config/ethereum_networks.json`), when printing values, or...

In GitLab by @fahree on Jan 7, 2021, 03:06 ADA probably has the same kind of thing.

In GitLab by @ApolloUnicorn on Mar 25, 2021, 02:09 changed the description

In GitLab by @fahree on May 26, 2021, 21:37 My guess is that the string contents get compiled to some variant of a `Bytes` type that thinks it's fixed-size, even...

In GitLab by @kwanzknoel on May 27, 2021, 15:58 assigned to @kwanzknoel

In GitLab by @kwanzknoel on Jun 2, 2021, 03:06 I have done a bit more digging: The `Bytes` type is variably sized. Within `consensus-code-gen` we call `compile-consensus-statement`. This calls `param-length`...

In GitLab by @kwanzknoel on Jun 2, 2021, 03:07 Another possible (simpler?) workaround is to do what etherjs does and just have fixed length strings, padded with null bytes. https://docs.ethers.io/v4/api-utils.html#bytes32-strings

In GitLab by @kwanzknoel on Jun 2, 2021, 03:30 marked this issue as related to #194