Kevin van Zonneveld

Results 198 comments of Kevin van Zonneveld

Don’t you think for some languages that are more class/object oriented you might get collisions between Math and String, or function names are going to sound less meaningful without the...

Ok, I'm cool with `packages/php/strings/number_format/index.js` and consistently using the class in module names `@locutus/php-array-array_reverse`. Tests are generated and extracted from header comments, I think we should probably not output the...

Wondering if @kukawski has any strong opinions or insights on this matter?

We can already write in ES6 as we do indeed also already transpile to ES5 so that could be a viable option yes. I don't have the time for it,...

The import seems wrong, there is a language level and a category/module level under which the functions are nested. Seems like perhaps you are importing more than you bargained for,...

Ah crypo, vs crypto, that seems a bug, let me check

Hm no, it seems to use `crypto` which is correct: ``` var crypto = require('crypto') ``` crypto is a node module, not sure how we could ship it

@LiuXuFei It's possible that in cleaning up the codebase, a regression was introduced. The original library was taken from here https://sourceforge.net/projects/bcmath-js/ and saved here https://github.com/kvz/locutus/blob/master/src/php/_helpers/_bc.js, making it standardjs compatible. Then,...

PS, if you are reading this as a maintainer, i also just completed a switch from Travis CI to GitHub Actions (reason: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing). The build is working and website is...