Kevin van Zonneveld comments

Results 198 comments of


                                            Kevin van Zonneveld

better style guide checking (properly parse bash vs regex-hit-and-miss)

A complete Bash parser in JavaScript transpiled from Go https://www.npmjs.com/package/mvdan-sh #hackernews

better style guide checking (properly parse bash vs regex-hit-and-miss)

also found this yesterday, just sharing as it might interest you https://google.github.io/styleguide/shell.xml

Investigate if shfmt is something for us

Seems you investigated already, nice 😄 Also seems it's not a clear 💯 yet, perhaps let's wait a bit for the project to mature before investing in it. Will leave...

Configuration files

You could likely do sth like: `config.env.sh`: ```bash export LOG_LEVEL=4 ``` `program.sh`: ```bash source config.env.sh ``` or no?

Feature Request: long-form only arguments or multi-letter short arguments

> I'm thinking of changing things so that long options are the default/required and short options are optional 💯

Long-form invalid arguments aren't caught

Throwing on that would have to be opt-in I feel, as I could imagine use cases where the argument is unknown / passed on to something else

Throw errors and/or don't consume next option when OPTARG missing

Failing hard in this case seems like a good idea. At least when options are defined that is.

HCL2 support

We’re not using this anymore, no, maybe I should add some deprecated message to the repo? Or if someone would like to write a pr for upgrading the hcl lib...

Arrays where they shouldn't be

Thanks for reporting! We're mostly using the other way around ourselves. We switched to the official hcl repo in https://github.com/kvz/json2hcl/pull/2, and I think this behavior should be reported upstream there,...

Clearing AMI without tag

I think you can, by pointing the `--mapping-key` to `name` instead of `tags`, check out this example: ```bash ❯ amicleaner --full-report --keep-previous 10 --mapping-key name --mapping-values tosip Default values :...