kvid

Results 393 comments of kvid

@project-set - thank's for reporting this error, but please provide information about your set of versions as described in [CONTRIBUTING.md](https://github.com/wireviz/WireViz/blob/master/docs/CONTRIBUTING.md) and how you installed WireViz and dependencies. Otherwise, it might...

@formatc1702 - I'm planning a rebase of this branch later today. Please tell me when you are finished merging in here for today, so I don't mess up your changes.

@martinrieder wrote: > I noticed that a similar issue has been found by @kvid in [#318 (review)](https://github.com/wireviz/WireViz/pull/318#pullrequestreview-1457016602) a year ago. Could you please check this again? > > It seems...

> what does errno evaluate to in that case? An `OSError` exception has `errno`, but `ValueError` has not. > Which version of Pathlib are you running? `pathlib` is a system...

> > I suggest you include `ValueError` like this: > > ```python > > except (FileNotFoundError, OSError, ValueError) as e: > > ``` > > Additionally, the if clause needs...

@formatc1702 seems to prefer not referring to issues or PRs in the source code - see https://github.com/wireviz/WireViz/pull/264#discussion_r1319052618 Referring to them in the body of commit messages is OK and often...

@martinrieder wrote: > Thanks. I will update the PR accordingly. > > I discovered an additional OS-specific bug with `expanduser()` that arises when the file name contains a tilde `~`...

I'm sorry for being unclear. When I wrote "_update the PR title and description to cover all sub-issues_", I didn't mean all details should be in the title. Please read...

@martinrieder wrote: > [...] > I discovered an additional OS-specific bug with `expanduser()` that arises when the file name contains a tilde `~` character. Should I include a fix for...

At Linux it's normal to evaluate a path with a leading `~Martin` to the home folder of a user named `Martin`, and it seems Python tries to make this work...