Vasily Kuznetsov

Results 30 comments of Vasily Kuznetsov

Sounds good. Let's do it.

I tried to reproduce this with the following test: ```py @pytest.mark.script_launch_mode('both') def test_subprocess(console_script, script_runner): console_script.write( """ import subprocess res = subprocess.run(['echo', 'foo'], stdout=subprocess.PIPE) print(res.returncode) print(res.stdout.decode('utf-8')) """ ) result = script_runner.run(str(console_script))...

Hi, @Stefaanhess, I have recently released version 1.0.0 that has quite significant changes. Could you downgrade to 0.2.0 and see if the speed changes? Then we can try to figure...

> First he got the error message: "fixture 'script_runner' not found" This would mean that pytest-console-scripts is not installed (or maybe something else went wrong). If the scripts run with...

Thanks for the ticket, John. You're right, the `std*` mocks are not very realistic. The whole extension was rolled together quickly and at that point I decided to just implement...

Interesting! `stdio-mgr` looks like something that it might make sense to use in `pytest-console-scripts`. It would be an additional dependency, but assuming you implement more realistic mocking there it might...

Aha, I just realized that `contextlib` decorators actually don't help me much because they don't create the mock streams, only replace them in `sys` -- I should have paid more...

Hi @bskinn, thank you for the background! > I'm okay with trying to add Python 2 support. I'd ask, though -- how far beyond 1/1/2020 are you planning on keeping...

Thank you @jayvdb! I don't have much to add in terms of requirements apart from the fact that for now `pytest-console-scripts` supports Python 2 (and people might be using it...

Yeah, thank you for that. Don't consider me strongly in favor of it though. I mean, it would make my life easier here but I'm not sure it's a good...