Kaan Uzdoğan

Results 134 issues of Kaan Uzdoğan

We should add the new Holesky testnet to our e2e tests similar to Goerli and Sepolia. The CI run that does this process is at: - Nightly tests: https://github.com/ethereum/sourcify/blob/staging/.circleci/nightly.yml -...

In https://github.com/foundry-rs/foundry/issues/6707 I raised it was said that the `evmVersion` field to metadata was added in `0.8.20` which was only a docs update by me https://github.com/ethereum/solidity/commit/1a23b7a60afcbf9f1cc97abc83ed6f912fb34a0f This although leaves me...

Related to #851 when matching with the creation bytecode, we are assuming the bytecode has the auxdata at the end of the contract when doing `splitAuxdata`. E.g.: https://github.com/ethereum/sourcify/blob/38fdfafa95d3ebe3c971321f8f5c86e3eedfa22d/packages/lib-sourcify/src/lib/verification.ts#L479-L481 This does...

From the discussion in https://github.com/ethereum/solidity/issues/14250 that is a similar bug to https://github.com/ethereum/sourcify/issues/618, I notice we might be verifying the contracts "perfectly" in a wrong way. This is because when we...

🪲 bug

Whenever a verification fails we are only returning a simple error message that the bytecodes don't match. Users for now would contact us and the first thing we usually do...

We should let users verify contracts using the standard-json input of the Solidity compiler. Projects, particularly older ones, do not keep their metadata after compilation. These projects are unable to...

enhancement

In the Remix plugin, when the user does a contract lookup and opens it in Remix file system they face the "File Write Approval" popup multiple times, for each new...

Following the create2 verification support, we might better be returning those create2 verified contracts whenever they are requested on another chain. Currently, we only return them only if the `chainId`...

needs-discussion
low-priority

Currently we are not checking the licenses of the contracts during verification. Potentially there may be contracts we should not store/verify with restrictive licenses. * [ ] Research what licenses...

Looking into verifying contracts from Etherscan, I notice **almost always** we can verify perfectly if the contracts are with standard-json input, which is great. This leaves me wondering if we...