sourcify icon indicating copy to clipboard operation
sourcify copied to clipboard

Revisit the match type in `extra-file-input` case

Open kuzdogan opened this issue 2 years ago • 0 comments

From the discussion in https://github.com/ethereum/solidity/issues/14250 that is a similar bug to https://github.com/ethereum/sourcify/issues/618, I notice we might be verifying the contracts "perfectly" in a wrong way.

This is because when we compile with extra files the metadata file would have been changed, and the hashes wouldn't match. However, in the implementation (ie. useAllSources) we are creating the CheckedContract with the old metadata (with the original sources) but with the sources + extra files. The generated Solidity JSON has files that are not present in the metadata.

That means the compilation is not reproducible.

View in Huly HI-474

kuzdogan avatar Jun 07 '23 17:06 kuzdogan