Kurt McKee
Kurt McKee
You're using bash conditional syntax, which may not be appropriate on Windows. Dotbot runs the `if` block using Python's `subprocess` module, which doesn't guarantee that you'll be running in whatever...
Thanks all for the feedback! @anishathalye Please let me know if you see anything that needs adjusting. I'm happy to make changes. Thanks for your work on dotbot, and for...
Re goals: I would ditch the VM requirement and just run the tests using pyfakefs to mock out filesystem isolation. Re old Python versions: there's no reason to rip out...
I've pushed [a branch](https://github.com/kurtmckee/dotbot/tree/test-on-windows-issue-309) that so far only demonstrates testing on all supported platforms. Running the tests uses standard practices: ```shell # Set up and activate a virtual environment, update...
Re pyfakefs: I've used it several times in the past and had been under the impression I could use it in a "chroot" capacity as well; I saw an `add_real_directory()`...
I'm making good progress, though CPython/PyPy compatibility with Windows and symlinks is poor until recent CPython versions: * Python 2.7 doesn't even have an `os.symlink()` function. * PyPy 2 and...
Thanks! I agree that dotbot should only support Python 3.8+ on Windows. Technically users could still run dotbot as admins and expect basic link configurations to work (like `~/.git -->...
Current status: ✔ All bash-based tests have been migrated to Python. ✔ Tests are passing on Windows (locally and on CI), including isort and black linters. ✔ As a bonus,...
Thanks for your work on PR #302!
My apologies, I overlooked the additional items! I'd like to discuss these items in more detail, but the discussion re: SAX parsers and fallbacks has been tearing at me for...