Alyssa Haroldsen

DRAFT: basic capsule unit test

2

This doesn't solve everything in the way I'd like, since there are a few challenges that need to be worked out: - There's no way to create a fake `ProcessId`...

Unsoundness transmuting &[u8] to &[Cell<u8>] when handling read-only memory

37

kernel/src/processbuffer.rs defines `impl for &'a ReadableProcesSlice` which contains only a transmute. However, this is unsound because `ReadableProcessByte`, of which `ReadableProcessSlice` is a slice of, is `Cell`, enabling interior mutability. Transmuting...

Hovering over an element should display a short description

1

I keep having to open up the reference to figure out what each menu item is supposed to do (e.g. dust). It would be helpful to provide a small popup...

Generally speaking, safe operations have no suffix, while their unsafe counterparts have `_unchecked`, `_unsafe`, or `_raw` like `mock_raw` does. So, I think it would be more ergonomic to switch all...

Use open_enum for enumerated properties

3

The pattern of using an integer newtype with named associated constants is exactly what the [open_enum macro](https://docs.rs/open-enum/0.3.0/open_enum/) aims to make cleaner. This pull should result in no semantic change. All...

Clarify that #[repr(transparent)] is valid without a non-ZST field

2

The following is valid, but the prior language suggests it is not: ```rust #[repr(transparent)] enum Banana { Phone, } #[repr(transparent)] struct Blooey(()); #[repr(transparent)] struct Orange; ``` Of note: it's still...

`ReadableProcessBuffer` should be sealed or `unsafe trait`

3

In order for `unsafe` code working with generic `ReadableProcessBuffer` (and `WriteableProcessBuffer` with #3756 implemented) to trust that their implementations of `ptr` to be correct, that code needs to either: -...

Add `WriteableProcessBuffer::mut_ptr`

3

`::ptr` returns `*const u8` and, due to its implementation, it's valid to `.cast_mut()` that and then (in a single thread) write to it so long as it's not empty (and...

Pass the kind of item to `ParseCallbacks::item_name`

1

### Input C/C++ Header ```C++ enum long_prefix_to_remove_foo { BAR = 0 }; int long_prefix_to_remove_bar(); ``` There is no way to implement `ParseCallbacks::item_name` that can follow different naming logic for these...

Add a `Builder::headers` helper

1

Much like `clang_args`, a helper for adding multiple headers in a chained builder expression. The signature should be: ```rust pub fn headers(self, headers: I) -> Self where I::Item: Into ```