Michael Yoo

Results 11 comments of Michael Yoo

@JorTurFer Yes I do. I’ll open a PR.

@JorTurFer I have a question. Currently the name of the trigger for the Pulsar scaler is "msgBacklogThreshold" (https://keda.sh/docs/2.15/scalers/pulsar/#trigger-specification). I'm wondering if I should integrate this feature into the existing Pulsar...

@JorTurFer Just to be clear, you're suggesting the former approach where I introduce a new value while keeping the old "msgBacklogThreshold" for 2 versions following the deprecation policy, right? Also,...

@JorTurFer Done! (for real this time)

@JorTurFer You suggested that I query the metrics server directly instead of querying HPA. I have modified the code (https://github.com/kedacore/keda/pull/6174#issuecomment-2372406599). If approved, modification to the helm chart is needed since...

@SpiritZhou I updated the CHANGELOG.md too.

> Thanks, I quickly checked the code, I haven't read full the getAverage... functions. > > But I would like to see more e2e tests (covering cases like scale 0->1,...

@zroubalik I'm currently unavailable right now. I'll make the changes and let you know within next week.