Michał Kukieła

> Feedback on design: the external link icon should be of grey color (for de-emphasiz) and not of blue ($theme). Ok. If you want it grey, then we do not...

> Feedback on design: the external link icon should be of grey color (for de-emphasiz) and not of blue ($theme). How about this?  > About the FAIR pledge, yes...

> I think I'd prefer the JS do the opposite. ie., start with no icon next to links, and have the JS add the icon to all text links (links...

@srid Please have a look at this. The links containing an image in the link text are now recognized before HTML is generated, so no JavaScript is needed. I'm not...

What do you think: should the icons appear in the backlinks section? I also see I need to fix the colors to make them consistent with other icons around.

> For backlinks, that can be done as part of https://github.com/EmaApps/emanote/issues/187 (not necessarily in this PR) I believe it's sufficient to add the `emanote-external` classes in `context.tpl`. Looks like it...

> Why do we need NoIcon differentiation at all? Can't we get rid of it? I'm not sure if I understand the question correctly. External links without an icon still...

> Do you see any issue with this change? The external links containing an image (or a wikilink) lose the `target='_blank'` and `rel='noopener'` attributes. These attributes are set by: ```...

This is going to be a heuristic. A better or worse one, but still. I don't believe we can cover all the usecases. I'm trying to illustrate this in the...

I've noticed that I duplicate the `emanote-external-icon`/`emanote-external-no-icon` classes if they are set by hand. Are you ok with changing `` to `Data.List.union` in this line? https://github.com/EmaApps/emanote/blob/d2ae1013094537f76692edc910bf36b2fb543107/src/Heist/Extra/Splices/Pandoc/Attr.hs#L21