kujyp

Results 5 comments of kujyp

What's the matter with this? In my test machine, all tests passed. It doesn't guarentee a stability. I didn't make any changes on https://github.com/JakeWharton/RxBinding/pull/433/commits/c51083ad2c0550fea409ef7d4cbc6420b59ca64d, but rxbinding module passed the tests....

@MickSparrow There are two problems here. 1. View.getViewTreeObserver() returns mFloatingTreeObserver In test case, view doesn't attach any contexts. So view.getViewTreeObserver() returns mFloatingTreeObserver. It doesn't invoke ViewTreeObserver.dispatchOnScrollChanged RxViewText.java `private final View...

@JakeWharton https://github.com/JakeWharton/RxBinding/pull/433/commits/5339796c09d9d28fd521a3e690fb6daa447e218a passed the ci pipeline. But I just made small changes, then https://github.com/JakeWharton/RxBinding/pull/433/commits/03685a01e45507eeae7bf06e44529337d173a322 failed. I have no idea why it failed with the Classes that I didn't touch. com.jakewharton.rxbinding2.view.RxViewSystemUiVisibilityTest...

It seems to be flaky tests, so I just leave it failed. I'm sorry for pushing empty commits. I need some feedbacks that I didn't do wrong.