Nathan Kuenzig
Nathan Kuenzig
Why was this issue closed? I am also trying to override a built-in lexer with aa lexer from a plugin using the same alias. I have certain language customizations that...
I'd think it would just be a simple change to have get_lexer_by_name check plugins for the specified alias before checking the built-in list.
I believe that there needs to either be a way to override the built-in lexers, styles, formatters, and filters or at least a way to _explicitly_ disable a built-in so...
I don't think it would be a security issue if I change it to have a command line argument to explicitly disable a built-in lexer/style/formatter/filter rather than making it so...
Yeah, I would think it would make sense as an explicit option in all forms of running pygments (command line, api, etc.)
I have removed the implicit plugin override changes and replaced them with explicit options for disabling lexers/styles/filters/formatters. Hopefully this alleviates concerns from @birkenfeld and @Jean-Abou-Samra .
Is there anything else I should do for this pull request before it is eligible for review? Sorry I haven't contributed to this project before and I didn't see anything...
> Looking at the CI, a rebase should fix the error there. I pulled the latest changes from master, but I'm not sure what you are suggesting to do with...
Gotcha. I'll look into rebasing instead of doing a merge tonight. Looking at it some more, there's a few changes I'd like to make as well to allow disabling to...
I've done the rebase as well as added more changes to allow for the disabled builtins to apply to other command line arguments. I'll take a look into writing tests...