Kohei Tokunaga
Kohei Tokunaga
> Hi -- sorry, but I don't understand. The commit message isn't editable, how would I sign it after-the-fact? @Stabledog Please take a look at https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message
Could you add tests?
Thanks for reporting this. I'm trying to fix this in #1599 .
@GerrySeidman Thank you for your interest! The remaining limitation is at least the support for [layer verification](https://github.com/containerd/stargz-snapshotter/blob/main/docs/estargz.md#content-verification-in-estargz) as mentioned in https://github.com/containers/storage/pull/795#issuecomment-799057091 .
Thanks for the patch. This seems to depend on the on-going patch on containerd (https://github.com/containerd/containerd/pull/8945 ) so let me turn this into a draft PR as of now.
I've sent patches to solve the CI failures: - https://github.com/containerd/containerd/pull/10287 is for fixing https://github.com/containerd/stargz-snapshotter/actions/runs/9327851434/job/25678303530?pr=1545#step:4:10542 - #1695 is for fixing https://github.com/containerd/stargz-snapshotter/actions/runs/9327851434/job/25678303459?pr=1545
@dmcgowan Another PR for containerd v2 migration (#1722) is posted recently. If this PR is still active, please let me know and rebase this PR so that we can prioritize...
Thanks for the question. We have several documents about that topic, including: - overview: https://github.com/containerd/stargz-snapshotter/blob/94b12086ace4119e86d2db0d6343d7c734b56671/docs/overview.md - estargz spec: https://github.com/containerd/stargz-snapshotter/blob/94b12086ace4119e86d2db0d6343d7c734b56671/docs/estargz.md
Yes, stargz snapshotter caches resources for a while for future use. If you want to ensure to clean up resources on the node, you can stop `containerd-stargz-grpc` process, remove files...
Yes, landmark is respected than PrefetchSize and no configuration flag is provided for limiting the prefetching size. Maybe we can introduce `MaxPrefetchSize` or `PrefetchSizeLimit` for this purpose. Patches are welcome...