Martijn van Beurden

Could you perhaps explain what this PR should fix?

I still haven't figured out what this patch does exactly (seems viewing the bug report requires privileges) but some comments, earlier versions and reviewing can be found here, under comments:...

I hadn't noticed it before, but this patch gives rise to two compiler warnings: ``` stream_decoder.c:3178:74: warning: comparison of integer expressions of different signedness: 'FLAC__int64' {aka 'long long int'} and...

I went through this patch again (and the comments on earlier versions in https://android-review.googlesource.com/c/platform/external/flac/+/1770797) and I still don't understand where this comes from. In theory the maximum size of a...

@NeelkamalSemwal There have been quite a few changes to the seeking code recently, could you try whether the problem is already solved without this PR? If not, could you consider...

> In theory the maximum size of a FLAC frame is unbounded, but when regarding sane frames (frames that aren't several times larger than the raw data they code for),...

@NeelkamalSemwal Do you still intend to update this PR or can I close it? I think the best fix is by comparing approx_bytes_per_frame with ``` (1

Is it possible for you to supply such a file? Have you tried re-encoding them with flac's decode-through-errors option? That's `-F` or `--decode-through-errors`

I've just tried this, and `flac` happily decodes such a malformed file without any problems. I actually get a warning that seems to be made specifically for this purpose: ```...

@ltx2018, @petterreinholdtsen as you both commented on #214 and #215 and @lvqcl as you contributed a few patches for out-of-memory handling, could you spare some time to take a look...