Keith Bartholomew

Results 7 comments of Keith Bartholomew

@stocker There's no easy workaround that doesn't involve a significant re-work of how SimpleSAMLPHP fits into the auth flow. It would end up being a huge change, and one that...

@stocker If you manage some workaround for this in your environment, I'm sure others would benefit from you including your solution here. PRs are welcome too, if you're so inclined...

It seems they're taking issue with lines like https://github.com/ktbartholomew/saml-20-single-sign-on/blob/master/src/saml/www/_include.php#L25 and would prefer that we lean on built-in WordPress actions to then trigger our behaviors. It looks like the `init` action...

Also, since this will drastically change the way users and IDPs interact with sites using this plugin, fixing this will probably necessitate a major revision bump.

@jeremykenedy https://github.com/ktbartholomew/saml-20-single-sign-on/pull/21 aims to resolve the things that the WP registry has taken issue with. Unfortunately, there's still a lot of work left to be done before that pull request...

It could be more straightforward to use https://github.com/onelogin/php-saml instead of hacking up SimpleSAMLPHP to behave the way we want it to.

@bmanth60 Yes, it look like trimming the header and footer is all that's needed.