Kirill Shnurov

Results 15 comments of Kirill Shnurov

@spovich sure, we can drop them if they cause any problems, but I don't see any reasons for making it right now. Is there some?

Added: simplified `Value` class, it's useless without `definition` & `instance`, so they should be passed during initialization. Also got rid of `method_missing`

@kenn hi! Have you had a chance to look into this?

Hi @kenn Using positions might sound more convenient in simple use cases, but these are the reasons I'm using values instead of positions: 1. It's simple, transparent and obvious. What...

> 3. Disagree — exactly why I'm reluctant to accept this PR — these new problems / confusions don't exist right now The old format also has its own problems,...

@kenn is there anything left that stops you from merging this?

After doing some testing I've found some very common cases that are completely broken either in master: ``` Expected: "test ***test another* test**" Received: "test ***test another* test" ``` ```...

@jwlee1108 @jajugoguma it's been a month, how's it going? :)

Found a workaround, add this to `application.rb`: ``` config.before_configuration do |app| ActiveStorage.draw_routes = false end ```

> You would still need to edit and/or delete `user.notifications.sms?` from everywhere in the code base, right? Otherwise it would raise an exception. Not if you're using `user.notifications.set?(:sms)`, which you...