Kevin Sheurs

Results 8 comments of Kevin Sheurs

i think the idea is just to override presentation type stuff (views, stylesheet, javascript, images, etc)... not controllers/models. that logic should be the same across themes.

ha i just happened to run that and was coming back here to let you know :) thanks man, that was it. hope this gets merged in soon!

have you noticed issues with calling theme_image_path directly? example: == "/assets/:theme/images/test-{digest}.png" (correct) == ":theme/images/test-{digest}.png" (incorrect) i would expect these to render the same paths, right? debugging now..

so far i've just been testing with theme_image_path. with config.assets.digest = false, it works as expected (path being /assets/:theme/images/test.png). if i set config.assets.digest = true, and precompile assets, that's when...

weird it seems to be working ok now. i was juggling a few things earlier, so maybe something else was off. for reference regardless my config/dir structure is below: initializers/theme_for_rails.rb...

actually sorry, the issue still exists. if config.assets.digest = false everything is ok w/ theme_image_path, theme_stylesheet_path, and theme_javascript_path. with config.assets.digest = true all the theme tag functions work properly but...

hey guys i came up with this and it seems to be working well for us: https://github.com/vhx/themes_for_rails/commit/3aedd9cc4b082664287e4d52f4fa06ad6fc6dca1 i started from lucasefe/master and my approach was to stop using routes and...

hey all, i will try and get tests working soon so i can do a pull request. sorry for the delay...