Kostiantyn Shchepanovskyi

Results 45 comments of Kostiantyn Shchepanovskyi

> Should we consider this project Orphan Looks like that. Last commit was more than year ago + 45 open issues.

It might be safer to apply something like https://maven.apache.org/plugins/maven-shade-plugin/ as there might be conflict between dependencies of different plugins (and those are out of control). Anyway, I was thinking that...

@alexejk @xinruozhishui can you please check GoLand logs? Maybe there is something helpful.

It might make sense to report this to JetBrains.

@jvolkman FYI Reported https://youtrack.jetbrains.com/issue/GO-10651 --- UPD: @fgm @s0xzwasd sorry, didn't see you reported it couple of hours ago.

`src/main/proto` should be added to a source set (gradle) or simply marked as a source root in IDEA.

I faced with the same problem, some syntax errors are not highlighted. As far as I understand, `parseTree` created inside of `org.antlr.jetbrains.adapter.parser.ANTLRParserAdaptor#parse(com.intellij.psi.tree.IElementType, com.intellij.lang.PsiBuilder)` does not contain error nodes for some...

In the `org.antlr.jetbrains.adapter.parser.ANTLRParseTreeToPSIConverter`, we do not intercept all errors: - `#visitErrorNode` is not invoked for non-existing `ErrorNode`-s (missing tokens, in this case) - `#enterEveryRule` does not check `ctx.exception` value -...

Following code solves the problem, but I'm not 100% sure that it is the best solution. ``` diff diff --git a/src/main/java/org/antlr/jetbrains/adapter/parser/ANTLRParseTreeToPSIConverter.java b/src/main/java/org/antlr/jetbrains/adapter/parser/ANTLRParseTreeToPSIConverter.java index bf2f787..e12351e 100644 --- a/src/main/java/org/antlr/jetbrains/adapter/parser/ANTLRParseTreeToPSIConverter.java +++ b/src/main/java/org/antlr/jetbrains/adapter/parser/ANTLRParseTreeToPSIConverter.java @@...

@Shan1024 I can publish my fork to maven central, if you want. It is used in https://plugins.jetbrains.com/plugin/8277-protobuf-support, it is quite stable and I think might be useful to others.