Karl Seamon
Karl Seamon
Sorry for the delay. I'm not sure that this is desirable in all cases. With your approach, we pay a performance penalty (Moving work from compile to link and indirectly...
ng-repeat's $watchCollection will do one one referential check per iteration per digest cycle (One watcher, numerous comparisons). Any bindings inside of it will additionally do dirty checks on each digest...
Popover edit should be usable now from experimental. The main thing I still need to add is a select style popover. There are also still some open questions about keyboard...
Of course, beware that while it’s in experimental, there can be breaking changes at any time, though I don’t have any planned right now.
It's tough to say when popover-edit will escape experimental. The main thing holding it up is a finalized spec for a11y / keyboard interaction from the UX folks. The current...
Related to internal ticket # 195133734
In concept, this looks fine. Played with it a bit. I think 300ms is too long - maybe try 100?
> > In concept, this looks fine. Played with it a bit. I think 300ms is too long - maybe try 100? > > Thanks for checking it out! Totally...
Looks like you need to run yarn lint in your branch and address those issues. It also looks like the unit tests are failing. You can run those with yarn...
> Kind reminder, would appreciate any feedback if I can do anything else to get this fully approved and merged, @kseamon, @andrewseguin, thank you very much. The change looks good...