Sankeerthan Kasilingam

Thanks @youngnick. I'll send a PR to cover these tests. Let's get others' opinions after the PR

Hi @youngnick, I sent a PR with a conformance test. The test cases were written to check the longest SNI when multiple TLS certs are available. If possible, please review...

@rainest Sorry for the confusion related to the proposed changes. I also looked at the same doc. The Longest Matching SNI was mentioned as support: core. The second proposed test...

> Looking good. Thanks for handling this. > > I think we can be more consistent with the variable naming. > > And as far as I can tell, we...

>And as far as I can tell, we don't increment error metrics every error returns. Just some clarifications needed on this(sorry if it's a dump question). https://github.com/parca-dev/parca/blob/573a48dc7860ba24e219e3ff327ea4b799ed56ae/pkg/debuginfo/store.go#L85 https://github.com/parca-dev/parca/blob/573a48dc7860ba24e219e3ff327ea4b799ed56ae/pkg/debuginfo/store.go#L88 Two error...

>You might also want to consider extracting validation logic to the helper function fro ease of instrumenting If I'm going to extract validation logic to a function, Can I extract...

@kakkoyun I have done following changes 1. changed the name of metrics as per your suggestions. 2. removed metrics for validationAttempts and validationErrors (since metrics were removed, i didn't extract...

Hi Team, I'm interested on this issue. Can I send a PR for this?

@tokers Thanks for your comments. I have fixed them. Will you be able to review the PR?

> I am a bit confused. Multi certs are `Implementation-specific` per the spec. How can we have a conformance tests for something Implementation-specific? @howardjohn Not sure my understanding is correct....