Krzysztof Rybka
Krzysztof Rybka
It looks like #703 #1161
IIRC, every 2 requests made in `batch_request_buffer_throttle` seconds 'enable' batch mode so even if you log in (1st request) and go do home page (2nd request) then gem in version...
`0.2.0` has the same problem
Any news about it? It would be nice to get this gem back from the graveyard.
> Do you need for Rails < 5.1? If no — please, use `erubi` instead. Unfortunately, I have an application on Rails 4.2 and I cannot easily update it.
Hi! Any chance to merge it?
Hi @BookOfGreg I think, I wanted to handle it in initializer [here](https://github.com/reactjs/react-rails/blob/81697239930e9c017e1bc739bfe8e2e8ee577fb7/lib/react/server_rendering/exec_js_renderer.rb#L13). IIRC, `compile` was raise `ProgremError` when some of npm packages wanted to access properties of `window` in SSR.
I'm not sure if it is doable. Now we call JS renderer with a JS code as a string so we lose any information about the location of the code.
I can see another problem. `email` and `login` should be unique as a pair. There shouldn't be a way to set the same value for `email` for user A and...
[Here](https://github.com/plataformatec/devise/wiki/How-To:-Allow-users-to-sign-in-using-their-username-or-email-address#for-activerecord) this is described.