Kenny Root

Results 134 comments of Kenny Root

I'll have to check whether default colorScheme is actually 1.

Thanks for the contribution, but I think font downloading belongs in ConnectBot and not the termlib component. I also want to rearrange the color schemes to be part of "profiles"...

I updated the issue with some more notes if you wanted to work on that.

Great work! I will review this thoroughly soon. おつかるさまです 🙇🏼‍♂️

This still has quite a few bugs, but I can fix them if you're not interested in working further on this. Here are the things I noticed: - When changing...

I created a small merge conflict for you. I changed the colorSchemeId default to -1L. Your change deletes the lines anyway, so it can be overcome by deleting the lines.

I have been testing this change, but I haven't yet concluded. You could probably guess from the termlib change. My response time is going to slow down quite a bit...

This might be solved by #1603 when it's committed to main.

Is there an existing issue or should I rewrite this FR to cover AWS S3, Azure Blob, and GCS? I can also write an implementation strategy if you're accepting outside...

The [target SDK must be upgraded](https://developer.android.com/google/play/requirements/target-sdk) to upload to Play Store. I'm not sure if you deleted the entire bug template or not, but the information requested in that template...