Kursat Demir

Results 7 comments of Kursat Demir

PR review from any of you is appreciated. @linxGnu || @goten4 || @laduchesneau. Thanks in advance.

@laduchesneau Thanks. I have just pushed one minor fix more. Please see the ref. below; Ref : https://en.wikipedia.org/wiki/GSM_03.38 "When there are 1 to 6 spare bits in the last octet...

Hi @laduchesneau. Have you had chance to test your SMSC? We had to active 7-bit coding in SMSC before using it.

Yeah, makes sense. As I said, that was something configurable in our SMSC, worked after we activated. Great that you verified with [cloudhopper-commons](https://github.com/twitter/cloudhopper-commons).

Hi @linxGnu . Sure, I can try to change as you suggested in the beginning of the next week. But could you please point the place where it breaks, or...

@linxGnu Hi again. I have pushed the changes as you requested. (Introduced gsm7bitPacked type instead). I appreciate if any of you review the PR when you have time.

Great to see the changes er merged. Thanks for a nice collaboration @laduchesneau @linxGnu