nerf-pytorch icon indicating copy to clipboard operation
nerf-pytorch copied to clipboard

A question regarding the variable ray_directions

Open OshriHalimi opened this issue 4 years ago • 1 comments

Based on the documentation here: https://github.com/krrish94/nerf-pytorch/blob/a14357da6cada433d28bf11a45c7bcaace76c06e/nerf/nerf_helpers.py#L85 I would expect ray_directions to contain unit vectors. However, numerically looking into the values, this is not the case - the values are close to 1 but have a large variation around the exact value (around 10%-20%).

Is this a bug? If not, what is the meaning of the vector magnitude?

Thanks!

OshriHalimi avatar Feb 06 '21 13:02 OshriHalimi

ray_directions is eventually normalized in run_one_iter_of_nerf.

airalcorn2 avatar Jan 28 '22 19:01 airalcorn2