Vitaliy Zaytsev

Results 16 comments of Vitaliy Zaytsev

@arnoldcui looks like you have problems with axios, not with koa-session @dead-horse this issue is pretty old and looks like it's not about issues inside koa-session

@ypliypli can you please provide more of your code? It will help if you create a minimum repo which repoduces this error i.e. only koa and koa-session and some of...

It think that this change should not break anything. There was no possibility to use keys prefixed with double underscore before and after this change. There is a possibilty to...

It is actually a breaking change. Because before this change cookie had `_session`, `_expire` and `_maxAge` extra keys which after this change will have double underscore prefix instead of one....

@reklatsmasters i was thinking today if it's possible to remove crc completly and simply compare `JSON.stringify`'ed representations of session before and after. What do you think about it?

@millette i don't think so. All `json-stable-stringify` does is keys sorting. We don't need it. If session object wasn't modified then `JSON.stringify`s output will not change.

> since a JS Date can only ever be in the system time zone I think that JS Date actually always UTC (because it only stores timestamps inside) and it...

@dcousens why would you shift date in the first place? Isn't it easier to just pass a time zone whe you parse string date like `parseFromTimeZone('2019-12-29 05:00', 'Asia/Tokyo')`?

@dcousens for scenario 1 there is a much easier way to get local time: ```js const local11am = parseFromTimeZone('11:00', user.timezone); ``` And then you compare Date instances `lastPostedAt > users11am`...

@dcousens you gave me 2 problems and i told you how you can solve them with only 2 functions. Do you have another problems/secenarios you forgot to mention? > 11:00...