Igor Kroitor

Hey) > But I was thinking why not ccxt in dart ? Well, the reason and the answer to "why not" questions is always the same: it would be great...

Hi! Please, check here: - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#how-to-contribute-code - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#multilanguage-support - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#derived-exchange-classes - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#new-exchange-integrations

> I ended up with iterating through responses and throwing InvalidOrder if any had success=false. I thought it should behave similar to fetchOrderBooks, supplying a mix of valid and invalid...

> I ended up with iterating through responses and throwing InvalidOrder if any had success=false. One thing to clarify here: I'd rather throw OrderNotFound if any of them was not...

@OleksijR-DevBrother we will need time to review and clean it up, at this point there's still a few parts that must be fixed, namely, the lack of sanitizing with safe*-methods...

> @kroitor, can you please tell the problem here? The transpiling is successfull and it seems that the rules are kept as well. If you could specify what is the...

Unfortunately, we cannot merge it, cause it violates multiple CONTRIBUTING guidelines and the tests fail: - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#how-to-contribute-code - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#multilanguage-support - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#derived-exchange-classes - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#new-exchange-integrations

@Walid-b4y if possible, please make sure that the tests pass and there's no conflicts on this PR. Namely, with `package-lock.json` – it shouldn't be removed, so we have to revert...

> Should [this PR](https://github.com/ccxt/ccxt/pull/9295) be closed? Not yet, it will be merged to credit the contributor.

@0xkarl hi! If possible, please remove the auto-generated files from this PR, leaving just a single source .js file: - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#multilanguage-support - https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#new-exchange-integrations