Johannes Altmanninger

Results 762 comments of Johannes Altmanninger

> This doesn't seem worth the added complexity to me. I don't know if complexity means UI or implementation here. One the one hand, this is one way to enable...

yeah this is d6791a836b8 (Include the autosuggestion in history if it was truncated https://github.com/fish-shell/fish-shell/issues/650, 2013-08-20) I wonder if this can go away with future multi-line autosuggestions? I.e. up-arrow could skip...

right, we should fix that (same for single-line autosuggestions (#12004)). (Your lines are very long though! Maybe extract a function)

> The new commits run `cargo run --package fish-fluent-check` in Haven't looked into the code but any reason why we can't use "cargo test" ? (I guess we'd need to...

> I changed `unic-langid` to `0.9.5`, since `0.9.6` requires Rust > 1.82+. yeah let's update to Debian Stable's 1.85 (and see if someone complains). AFAIK this means we still support...

> > yeah let's update to Debian Stable's 1.85 (and see if someone complains). > > Sounds good. That version also allows us to migrate to the 2024 Rust >...

Maybe the first step is to resurrect `docker/jammy-asan.Dockerfile` (ideally making it work with moving ubuntu versions). Assuming this is more convenient than github actions. If we're reasonably sure it's an...

can't reproduce, please give a full but minimal reproducer (without direnv and without subshell if possible) $ fish_add_path -ag / set -g fish_user_paths / $ set -S PATH $PATH: set...

Nice to see that the test is working (looks like we don't have other tests for this), I hope it wasn't too annoying. I just realized that this is because...

> I need to rewrite the entire thing again No, you can use undo: `ctrl-z` or `ctrl-/` (like in Bash). --- FWIW [here](https://github.com/fish-shell/fish-shell/issues/10926#issue-2753198774) is the full set of bindings that...