Johannes Altmanninger
Johannes Altmanninger
I'd like to understand better why we need `NodeRef`, can we not pass a normal reference to a node enum? Also I'd like to evaluate the impact of proc macros...
prefer rebase on master instead of merging for this type of change. Merge commits are a complex thing
> manually copying the commit hashes (since the target hash for a new cut will always be different each time). This is a point for using a Git client like...
Neat, I want this too, don't want to fall behind on street cred ;)
> `:syntax iskeyword` could be used instead, so that commands are still highlighted correctly. Cool! I tried `:syntax iskeyword=@,48,57,-,_,.,/` but this seems to mess up other syntax definitions, for example...
I think it's fine to always squash fixups eagerly. People who have remembered a previous state can use `git range-diff`
looks great, thanks! I'm using it as well, it's very handy
> A version of the range highlighter that reads the string portion of the range-specs as highlighter path instead of face name would be useful here. that's a neat idea....
`:doc` sidesteps this problem by making the `*hover*` buffer readonly. We could do the same for `*hover*`. It's not ideal but probably also not a big deal. > compared to...
> But that would require the entire list of highlighters to be added and removed for every change. Currently, each `lsp-diagnostics` deletes *hover* in creates it afresh (including all highlighters)....