Johannes Altmanninger
Johannes Altmanninger
works for me, do you have steps to reproduce?
yeah `fish -N` is currently broken by this PR (and you probably don't want to use `-N` currently anyway). Your old key bindings should keep working but the compatibiltiy work...
I don't think `fish_sequence_delay` is the ideal long-term UI. I'd rather have fish wait indefinitely but (after some initial delay?) somehow echo the currently pending sequence (but crucially, don't execute...
One option would be to use the names from /usr/include/xkbcommon/xkbcommon-names.h but unfortunately `XKB_MOD_NAME_ALT` is `Mod1`, which is not great depending on the audience Probably kitty key names (like `shift+enter`) are...
I've compiled a list of changelog additions (same in PR description and in the last commit), we can use that as guidance for deciding about the user-visible changes. This is...
that's unrelated but I've pushed a fix (to master and here). I've fixed the other problems mentioned, anything else?
yeah the plan for the future is to also use the other progressive enhancements
> Okay, running fish_key_reader from this in a terminal that does not support CSI u (konsole), it seems to move the cursor up constantly? > > EDIT: > > Oh...
ASan `test_terminal.py` is already flaky on master; not sure about macOS `test_histfile.py`, that one just seems to hang sometimes
I think this is probably fine to merge with little modification but we should look into whether our trait hierarchy is still necessary, given that it overlaps with the methods...