Tomas Krnak

Combine multiple `CtOption`al results

1

### My problem ```rust struct C(A, B); fn create_c(a: &[u8], b: &[u8]) -> CtOption { let a: CtOption = A::from_bytes(a); let b: CtOption = B::from_bytes(b); // ??? } ``` ###...

Add support for Zcash unified addresses - memory optimized

11

specification: https://zips.z.cash/zip-0316 optimization: f4jumble now uses C blake2b module

Support `USE_{SOME COIN}` compilation flags

7

Compilation flags of type `USE_*` are not separable, i.e. they can be all disabled (by `BITCOIN_ONLY=1`), or all enabled (otherwise), but they cannot be set individually. For example for `USE_ETHEREUM=0`...

`BITCOIN_ONLY` feature is not additive

1

In other words, `BITCOIN_ONLY` "feature" disables functionalities instead of adding them. This is a design problem because the presence of a non-additive feature thwarts attempts to correctly define other features....

Zcash shielded transactions

2

# Orchard shielded transactions for Trezor T. work in progress . you can use this PR for tracking my activity ### Links [ZFND grant](https://grants.zfnd.org/proposals/1792958360-trezor-support-for-zcash-shielded-transactions) [documentation](https://github.com/jarys/ztrezor/blob/main/doc/README.md) [milestone M.1 report](https://github.com/jarys/ztrezor/blob/main/M.1_report.md) [milestone M.2...

feat(core): add Zcash Rust primitives

3

This PR adds - pasta curves arithmetic (from `pasta_curves` crate) - redpallas signature scheme (from `reddsa` crate) - poseidon hash function (my own tested implementation) Three pasta curves struct (`Fp`,...

Zcash shielded transactions

5

# Orchard shielded transactions for Trezor T. ### Links [ZFND grant](https://grants.zfnd.org/proposals/1792958360-trezor-support-for-zcash-shielded-transactions) [Zcash documentation (pdf)](https://zips.z.cash/protocol/protocol.pdf) [documentation](https://github.com/jarys/ztrezor/blob/main/doc/README.md) [milestone M.1 report](https://github.com/jarys/ztrezor/blob/main/M.1_report.md) [milestone M.2 report](https://github.com/jarys/ztrezor/blob/main/M.2_report.md) ### Todos - [x] device tests - [x] more...

`confirm_output` does not render subtitle

1

https://github.com/trezor/trezor-firmware/blob/3536d86fa913ff97aa8b8db0332b1cd239b45719/core/src/trezor/ui/layouts/tt/__init__.py#L513-L514 ### Problem Function `confirm_output` does not render subtitle, because `text.content` is modified by `normal()` and then re-set by assignment. ### Solution Replace ```py text.content = [font_amount, amount, ui.NORMAL, color_to,...

Insufficient blinding of `z_poly`

2

Method `StandardComposer::add_blinding_factors` uses 4 random scalars to blind wire polynomials `w_l` and `w_r` and the permutation polynomial `z_poly` polynomial. Also notice that blinding factors of `w_o` and `w_4` does not...

tl;dr: Crate does not enforce a transcript to be initiated with the circuit description. It follows that a circuit producer can manipulate circuit selectors to create a **forged proof**. ##...