Kirill Müller

Results 2418 comments of Kirill Müller

`mutate_if_row()` is better, less noise and works for updating multiple columns at once. I've heard this question now multiple times in workshops. I see your point, we need to copy...

There is good support for this in the dm package. Note how it also can print the `dm_rename()` calls needed to manually rename the columns to disambiguate: ``` r library(conflicted)...

How many `find_scale()` are there in a usual plot? Should we avoid calling `find_scale()` for bare unclassed vectors? Implementers can optimize by adding an `"env"` attribute to their `scale_type()` return...

Crazy thought: what if we reversed responsibility here? If each `mutate()` registered the resulting data frame together with its focus columns in a global variable (collection?) so that attributes remain...

Thanks for your feedback. I need to look into the confused column order, something doesn't seem to be right. I have thought about adding a vertical separator if columns are...

The column order is correct. We have three focus column as a result of the operation: the two input columns, and the output column. The focus columns are shown in...

Would it work to use `rename()` on the `y` argument first before calling the `rows_...()` functions?

I still don't see how it's cleaner if the `rows_...()` functions expect `colnames(y)` to be a subset of `colnames(x)` anyway, as you have also confirmed. On the contrary, adding this...

Yeah, let's keep the reexport. I wish there was a way to simplify this. We *could* notify maintainers now, and plan for a breaking patch release (1.1.1 or 1.1.2) in...

The roundtripping seems to improve if we use {styler} to style the `.R` and/or the `.Rmd` file.