dplyr icon indicating copy to clipboard operation
dplyr copied to clipboard

Avoid `type_sum()` reexport

Open krlmlr opened this issue 4 years ago • 2 comments

Users should import it from pillar (or tibble if absolutely necessary), or better implement vec_ptype_abbr() .

dplyr also reexports many more functions that are now deprecated.

This is a breaking change.

krlmlr avatar Oct 25 '21 04:10 krlmlr

See discussion in #6281

hadley avatar Jul 22 '22 19:07 hadley

To summarize, in https://github.com/tidyverse/dplyr/pull/6284 I removed the tbl_sum() re-export, but type_sum() is imported into many other packages through dplyr and will be hard to remove https://github.com/tidyverse/dplyr/pull/6281#issuecomment-1137739984

DavisVaughan avatar Jul 22 '22 19:07 DavisVaughan

Yeah, let's keep the reexport. I wish there was a way to simplify this. We could notify maintainers now, and plan for a breaking patch release (1.1.1 or 1.1.2) in a month or so from now, with just that change. But that seems so much work for so limited gain. I gave up on similar issues for pillar/tibble.

krlmlr avatar Aug 18 '22 23:08 krlmlr