Kirill Müller

Results 2418 comments of Kirill Müller

@copilot: Merge `main` and follow updated `AGENTS.md` . Double-check triangular and hexagonal in the documentation.

@copilot: Prefer `GATTR`, use explicit arguments instead of passing on ellipsis. Add ellipsis before optional arguments.

@szhorvat: Copilot complains that > Cannot use GATTR yet as `igraph_hexagonal_lattice` is not in the base C interface definitions. ... What's the process here?

This is showing weird ``` fatal: detected dubious ownership in repository at '/root/workspace' ``` errors when run. Why do we need an R wrapper for a shell call? We can...

Need to look at the error messages together.

We no longer run `make` in Docker, instead the `Makefile` contains `docker run` instructions.

I see. Other package systems such as R have similar issues. In R, there is a check that verifies that only the relevant files are included. Is there a similar...

Maybe a reference to https://github.com/igraph/rigraph/blob/main/src/README.md, and document there? I agree the current docs are sparse.

I use: ```sh docker run --rm -ti --platform linux/amd64 -v $(pwd):/root/workspace ghcr.io/cynkra/rig-ubuntu-igraph:main make -f Makefile-cigraph ``` for full reproducibility. The only noisy things are lex and yacc, we could add...