rigraph icon indicating copy to clipboard operation
rigraph copied to clipboard

refactor: create helper function for code regeneration

Open maelle opened this issue 1 year ago • 4 comments

Related to #742

Questions

  • what other files can be regenerated
  • should there be a special value of file for regeneration all of them (NULL)

maelle avatar Feb 12 '24 09:02 maelle

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] avatar Feb 12 '24 09:02 aviator-app[bot]

This is showing weird

fatal: detected dubious ownership in repository at '/root/workspace'

errors when run.

Why do we need an R wrapper for a shell call?

We can work together on cleaning up the process and the documentation.

krlmlr avatar Feb 12 '24 19:02 krlmlr

Why do we need an R wrapper for a shell call?

I thought it'd be smoother (since I am mostly working in the R console) but if it's not possible, I'll keep using the shell call.

maelle avatar Feb 13 '24 08:02 maelle

Need to look at the error messages together.

krlmlr avatar Feb 20 '24 15:02 krlmlr

We no longer run make in Docker, instead the Makefile contains docker run instructions.

krlmlr avatar Apr 09 '24 13:04 krlmlr