Kirill Müller comments

Results 2418 comments of


                                            Kirill Müller

start work on vignette

Thanks, this is very accessible! I have a script to do the bulk rename ops, I applied it to the current text.

start work on vignette

Thanks, this is a good addition. I noticed two things: - I'm using bold face (two-star emphasis) in exceptional situations only, perhaps once per article at most. If really necessary,...

docs: improve fallbacks vignette

Need to review with `git diff --word-diff` .

docs: improve fallbacks vignette

Split into two commits.

docs: improve fallbacks vignette

Interesting. I'm avoiding too many references to other articles inside the text because I want the reader to stay with me and not jump around. That's why I strive to...

docs: improve fallbacks vignette

@copilot: Resolve conflicts.

Use `as.numeric(seq_len(n))` in favor of `seq(1, n)`

Yeah, my `seq_numeric()` would special-case for the `n == 0` edge case.

Use `as.numeric(seq_len(n))` in favor of `seq(1, n)`

`seq(1, x)` is much faster, as the benchmark shows. Because the natural sequence is the default argument for many input functions, I suspect that this case is pretty frequent and...

Use `as.numeric(seq_len(n))` in favor of `seq(1, n)`

🤦 🤦 You're right, of course. But the test isn't representative either: ``` r bench::mark( sum(seq(1, 10000000, 1)), sum(as.numeric(rlang::seq2(1, 10000000))), sum(as.numeric(seq_len(10000000))) ) #> Warning: Some expressions had a GC in...