Kirill Müller comments

Results 2418 comments of


                                            Kirill Müller

here v1.0.2

Thanks. For now, please use here v1.0.1 or the lower-level rprojroot package for custom criteria. @jennybc: How do you feel about detecting Quarto projects?

here v1.0.2

An option that allows for a character vector that defines the active criteria? Or alternatively a list of criterion objects?

`tibble` 3.2.1.9017: some errors in running vignette code

Thanks. Does `vignettes/r4ds.mmd` exist? The errors in the vignette code are meant to be caught. Can we run the check without `--no-build-vignettes` ?

`tibble` 3.2.1.9017: some errors in running vignette code

What is the problem with using Pandoc?

`tibble` 3.2.1.9017: some errors in running vignette code

Can we make that a build requirement?

`tibble` 3.2.1.9017: some errors in running vignette code

Thanks, Sergey. It's tricky -- pandoc is universal on all platforms that matter in practice (that is, for the vast majority of users). I hear it for the first time...

`tibble` 3.2.1.9017: some errors in running vignette code

IIUC, fixing the Haskell compiler where it's broken allows us to pull in pandoc?

`tibble` 3.2.1.9017: some errors in running vignette code

So, the problem is that newer GHC doesn't work for older platforms? Is this fixable upstream? To properly support `--no-build-vignettes`, we'd also need infrastructure to check this use case in...

`tibble` 3.2.1.9017: some errors in running vignette code

All valid points. All I'm saying is that I can't spend time on the implementation. If anyone wants to chime in, happy to review. I see failures consistent with your...

`tibble` 3.2.1.9017: some errors in running vignette code

Thanks for the heads-up. Should we add `purl = TRUE` to some chunks as described in https://stat.ethz.ch/pipermail/r-package-devel/2024q2/010871.html ?